Quickstarts diagrams update #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <[email protected]>
|
Stale PR, paging all reviewers |
msfussell
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Couple of changes
- SmartDetectorActor should be SmokeDetectorActor - See https://docs.dapr.io/getting-started/quickstarts/actors-quickstart/ in the code
- For Service Invocation it should say Name Resolution instead of DNS. DNS is one example in Kubernetes, but Name Resolution is general component. For example when used locally (no kubernetes) this is not DNS.
The rest look good
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Couple more suggestions to put labels on arrows and naming
- Cron and Postgres bindings have lost the "input" and "output" labels
- On configuration add "Get or Save Key/Value"
- On Secret API 1) Between App and Dapr add GetSecret for the call 2) This was called OrderProcessor and now has been called MyApp. I would revert the name to Order Processor.
Signed-off-by: Hannah Hunter <[email protected]>
…o issue_4219-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update diagrams to match style in the new Dapr diagrams deck
Issue reference
PR will close: #4219